Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16469 container: Lower log level for cont_aggregate_interval - b26 #15283

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Oct 9, 2024

To reduce the side-effect caused by frequent log with -DER_INPROGRESS.

Allow-unstable-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Oct 9, 2024

Ticket title is 'IOR Easy performance low with EC_16P2GX'
Status is 'In Progress'
Labels: 'daos_ecb_scale,pre_acceptance_issues'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16469

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15283/1/testReport/

@Nasf-Fan
Copy link
Contributor Author

Not need it any longer

@Nasf-Fan Nasf-Fan closed this Oct 24, 2024
@Nasf-Fan
Copy link
Contributor Author

Reopen it until #15335 is ready

@Nasf-Fan Nasf-Fan reopened this Oct 24, 2024
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 24, 2024
To reduce the side-effect caused by frequent log with -DER_INPROGRESS.

Allow-unstable-test: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan marked this pull request as ready for review October 24, 2024 16:01
@Nasf-Fan Nasf-Fan requested review from a team as code owners October 24, 2024 16:01
@Nasf-Fan Nasf-Fan changed the title DAOS-16469 container: Lower log level for cont_aggregate_interval DAOS-16469 container: Lower log level for cont_aggregate_interval - b26 Oct 24, 2024
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues testing with this at scale on Aurora

@mjean308 mjean308 mentioned this pull request Oct 24, 2024
18 tasks
@mchaarawi mchaarawi merged commit 70b12e3 into release/2.6 Oct 24, 2024
45 of 50 checks passed
@mchaarawi mchaarawi deleted the Nasf-Fan/DAOS-16469_t2_b26 branch October 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

4 participants